Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use /bin/bash instead of /sbin/nologin as default shell for default user as s2i-core did #194

Merged
merged 1 commit into from
Nov 10, 2023
Merged

use /bin/bash instead of /sbin/nologin as default shell for default user as s2i-core did #194

merged 1 commit into from
Nov 10, 2023

Conversation

zmiklank
Copy link
Contributor

@zmiklank zmiklank commented Nov 9, 2023

@zmiklank
Copy link
Contributor Author

zmiklank commented Nov 9, 2023

[test-all]

@zmiklank zmiklank marked this pull request as ready for review November 9, 2023 14:27
phracek
phracek approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks I did not hit any issues.

@phracek phracek merged commit abb7aa1 into sclorg:master Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phracek phracek phracek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate /sbin/nologin as default shell for default user, and change it if needed
2 participants
@zmiklank @phracek