-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test for installing a plugin #234
Conversation
[test] |
Test failed:
But it looks like it needs #235 |
[test] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests passed, but I have missed the documentation about plugin.
test_connection "${test_name}" root rootpass | ||
ip=$(ct_get_cip "${test_name}") | ||
|
||
mysql_cmd "$ip" "root" "rootpass" -e "INSTALL PLUGIN SQL_ERROR_LOG SONAME 'sql_errlog' \G" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SQL_ERROR_LOG is the plugin or SONAME? I do not follow.
It is not clear to me as a database dummy folk. Is it documented somewhere?
If not, can you please add this to documentation?
This test only follows what is documented in upstream: https://mariadb.com/kb/en/sql-error-log-plugin/ |
This will fail until the plugin dir is fixed in the base.cnf file (fix suggested in #235).