Add example how to enable extension #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @hhorak! 👍 |
|
[test][test-openshift] |
|
Wouldn't it be better for users to have environment variables for that ? For example, if a user want to enable hstore, shipped by default, having to do a separate container is a bit annoying, while it could be done with a variable POSTGRES_EXTENSIONS, who would run CREATE IF NOT EXISTS at start on all extensions in the list (either space separated, or comma separated, whatever is the most consistent with others containers). |
|
So I went ahead with #399 (with tests and docs). |
|
[test] |
|
[test-openshift] |
|
[test] |
|
@hhorak Please generate also source via distgen. Let's get test it and merge it. Generated sources are outdated. |
hhorak
force-pushed
the
example-extension
branch
from
cb84291 to
ebc071a
Compare
|
Rebased. |
|
[test] |
phracek
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: This would deserve a test as well.