Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for verifying postgresql image in a remote OpenShift cluster #308

Merged
merged 2 commits into from
Feb 6, 2019

Conversation

hhorak
Copy link
Member

@hhorak hhorak commented Feb 3, 2019

This adds a new make option make test-openshift-remote-cluster that runs test/run-openshift-remote-cluster and it runs the test within a remote OpenShift cluster. It requires oc command to exist and being logged in in a working cluster. The same functions are also added into run-openshift script, so those are tested during PR tests.

@hhorak
Copy link
Member Author

hhorak commented Feb 3, 2019

[test-openshift]

@hhorak
Copy link
Member Author

hhorak commented Feb 5, 2019

BTW this PR requires also a change in container-common-scripts: https://github.com/sclorg/container-common-scripts/pull/108/files

@praiskup @pkubatrh WDYT? I'd like to create a similar PR for other container images, but would like to see whether it is the correct way to do it first.

@praiskup
Copy link
Contributor

praiskup commented Feb 5, 2019

Looks like just (a rather large) file movement, and adding one new test which is possible to run against local or remote OpenShift cluster. If I interpret that correctly, it sounds wise - we should move as many tests as possible into the "common" tests subset... LGTM.

@hhorak
Copy link
Member Author

hhorak commented Feb 6, 2019

Yes, it is exactly that. We might move the rest or the functions as well, although I doubt they will "just work" on remote cluster as they are written now. It will probably need some more adjustments, that I did not try yet. Merging now, and a new issue reported to track the porting of rest of the tests as #311.

@hhorak hhorak merged commit 7ab45d0 into sclorg:master Feb 6, 2019
@praiskup
Copy link
Contributor

praiskup commented Feb 6, 2019

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants