Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make upstream tests as separate make target #415

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

zmiklank
Copy link
Contributor

+ small fix in a separate commit

Setting as draft for now.

@zmiklank
Copy link
Contributor Author

Depends on: sclorg/container-common-scripts#352

@zmiklank zmiklank marked this pull request as ready for review November 23, 2023 08:23
@zmiklank zmiklank marked this pull request as draft November 23, 2023 08:31
@zmiklank zmiklank marked this pull request as ready for review November 23, 2023 11:43
Makefile Outdated Show resolved Hide resolved
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for separation upstream tests.

@zmiklank
Copy link
Contributor Author

zmiklank commented Dec 7, 2023

[test]

@zmiklank
Copy link
Contributor Author

zmiklank commented Dec 7, 2023

There seems to be some problem with test/examples/from-dockerfile/Dockerfile*. I'll need to debug this. Until then moving this PR back to draft.

@zmiklank zmiklank marked this pull request as draft December 7, 2023 08:57
@zmiklank
Copy link
Contributor Author

zmiklank commented Dec 7, 2023

Test failures are caused from within the nodejs-app - it is not related to this PR. Explanation can be seen here: sclorg/nodejs-ex#251 (comment)

@zmiklank zmiklank marked this pull request as ready for review December 7, 2023 16:32
@zmiklank zmiklank merged commit 863366c into sclorg:master Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants