-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perl image 5.30-mod_fcgid for RHEL8 reached EOL in Nov 2023 #292
Conversation
This pull request removes it from Makefile, building and testing Signed-off-by: Petr "Stone" Hracek <[email protected]>
[test-all] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
When I grep for 5.30-mod_fcgid
I still see some occurrences in test/run-modfcgid
, test/test-lib-perl.sh
and README.md
files. Should they be removed too?
Also, I think 5.30-mod_fcgid
should be removed from testing conf files.
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
@pkubatrh @zmiklank PTAL. Thanks
As you can see. E.g. https://github.com/sclorg/s2i-perl-container/blob/master/5.34/test/run is reference to test/run-modfcgid, so this file should not be removed now. The rest is correct and I will update PR by next commits. |
Thanks for the additional commits.
I mean the main README: Lines 100 to 101 in 6e3e6d3
|
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Addressed by commit 155d42a |
[test] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks :) I would also suggest squashing this, but I am also OK with these commits as they are.
Perl image 5.30-mod_fcgid for RHEL8 reached EOL in Nov 2023
This pull request removes it from Makefile,
building and testing