Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perl image 5.30-mod_fcgid for RHEL8 reached EOL in Nov 2023 #292

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

phracek
Copy link
Member

@phracek phracek commented Dec 21, 2023

Perl image 5.30-mod_fcgid for RHEL8 reached EOL in Nov 2023

This pull request removes it from Makefile,

building and testing

This pull request removes it from Makefile,

building and testing

Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Copy link
Member Author

phracek commented Dec 21, 2023

[test-all]

@phracek
Copy link
Member Author

phracek commented Jan 8, 2024

@pkubatrh @zmiklank PTAL. Thanks

Copy link
Contributor

@zmiklank zmiklank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

When I grep for 5.30-mod_fcgid I still see some occurrences in test/run-modfcgid, test/test-lib-perl.sh and README.md files. Should they be removed too?

Also, I think 5.30-mod_fcgid should be removed from testing conf files.

@phracek
Copy link
Member Author

phracek commented Jan 9, 2024

@pkubatrh @zmiklank PTAL. Thanks

Thanks for the PR.

When I grep for 5.30-mod_fcgid I still see some occurrences in test/run-modfcgid, test/test-lib-perl.sh and README.md files. Should they be removed too?

Also, I think 5.30-mod_fcgid should be removed from testing conf files.

As you can see. E.g. https://github.com/sclorg/s2i-perl-container/blob/master/5.34/test/run is reference to test/run-modfcgid, so this file should not be removed now.
The file 5.30-mod_fcgid/README.md is updated and marked as deprecated.

The rest is correct and I will update PR by next commits.
See c567925 and da0212e

@zmiklank
Copy link
Contributor

zmiklank commented Jan 9, 2024

Thanks for the additional commits.

The file 5.30-mod_fcgid/README.md is updated and marked as deprecated.

I mean the main README:

For information about usage of the Dockerfile for Perl 5.30 - mod_fcgid version,
see [usage documentation](5.30-mod_fcgid/README.md).

Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Copy link
Member Author

phracek commented Jan 10, 2024

Thanks for the additional commits.

The file 5.30-mod_fcgid/README.md is updated and marked as deprecated.

I mean the main README:

For information about usage of the Dockerfile for Perl 5.30 - mod_fcgid version,
see [usage documentation](5.30-mod_fcgid/README.md).

Addressed by commit 155d42a

@phracek
Copy link
Member Author

phracek commented Jan 10, 2024

[test]

Copy link
Contributor

@zmiklank zmiklank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks :) I would also suggest squashing this, but I am also OK with these commits as they are.

@phracek phracek merged commit b3fdebd into master Jan 11, 2024
6 checks passed
@phracek phracek deleted the perl_530_rhel8_eol_nov branch January 11, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants