feat(smartctl): update for smartmontools 7.5

completions/smartctl

@@ -1,33 +1,67 @@
 # bash completion for smartctl(8)                          -*- shell-script -*-
+# Updated for smartmontools 7.5 (released 2025-04-30)
 
+_comp_cmd_smartctl__set_nospace_if_incomplete()
+{
+    local i
+    for i in "${!COMPREPLY[@]}"; do
+        if [[ ${COMPREPLY[i]} == *[,=] ]]; then
+            compopt -o nospace
+            break
+        fi
+    done
+}
 _comp_cmd_smartctl__device()
 {
     case $cur in
-        areca* | 3ware* | megaraid* | cciss*)
-            _comp_compgen -- -W '${cur%%,*},{0..31}'
+        3ware,* | areca,* | cciss,* | megaraid,*)
+            _comp_compgen -P "${cur%%,*}," -- -W '{0..31}'
+            ;;
+        aacraid,*,*,*,*) ;;
+        aacraid,[0-7],[0-7],*)
+            _comp_compgen -P "${cur%,*}," -- -W '{0..31}'
+            ;;
+        aacraid,*,*,*) ;;
+        aacraid,[0-7],*)
+            _comp_compgen -P "${cur%,*}," -- -W '{0..7},'
+            compopt -o nospace
+            ;;
+        aacraid,*)
+            _comp_compgen -P "aacraid," -- -W '{0..7},'
+            compopt -o nospace
+            ;;
+        hpt,*/*/*/*) ;;
+        hpt,[1-4]/[1-8]/*)
+            _comp_compgen -P "${cur%/*}/" -- -W '{1..8}'
+            ;;
+        hpt,[1-4]/*)
+            _comp_compgen -P "${cur%%/*}/" -- -W '{1..8}{,/}'
+            compopt -o nospace
+            ;;
+        hpt,*)
+            _comp_compgen -P "hpt," -- -W '{1..4}/'
+            compopt -o nospace
             ;;
-        hpt*)
-            _comp_compgen -- -W 'hpt,{1..4}/{1..8} hpt,{1..4}/{1..8}/{1..5}'
+        jmb39x,* | jmb39x-q,* | jmb39x-q2,* | jms56x,*)
+            _comp_compgen -P "${cur%%,*}," -- -W '{0..4}'
+            ;;
+        sssraid,*,*,*) ;;
+        sssraid,[0-7],*)
+            _comp_compgen -P "${cur%,*}," -- -W '{0..31}'
+            ;;
+        sssraid,*)
+            _comp_compgen -P "sssraid," -- -W '{0..7},'
+            compopt -o nospace
             ;;
         *)
-            _comp_compgen -- -W 'ata scsi sat usbcypress usbjmicron usbsunplus
-                marvell areca 3ware hpt megaraid cciss auto test'
-            case "${COMPREPLY[@]}" in
-                areca | 3ware | hpt | megaraid | cciss)
-                    compopt -o nospace
-                    ;;
-            esac
+            _comp_compgen -- -W 'auto test ata scsi nvme{,\,}
+                sat{,\,auto}{,\,12} usb{jmicron,prolific,sunplus}
+                snt{asmedia,jmicron,realtek}{,/sat} 3ware, aacraid, areca,
+                cciss, hpt, megaraid, sssraid, jmb39x{,-q,-q2}, jms56x,'
+            _comp_cmd_smartctl__set_nospace_if_incomplete
             ;;
     esac
 }
-_comp_cmd_smartctl__test()
-{
-    [[ $cur == @(pending|scttempint|vendor), ]] && return
-    _comp_compgen -- -W 'offline short long conveyance select, select,redo
-        select,next afterselect,on afterselect,off pending, scttempint,
-        vendor,'
-    [[ ${COMPREPLY-} == *, ]] && compopt -o nospace
-}
 _comp_cmd_smartctl__drivedb()
 {
     local prefix=
@@ -38,13 +72,44 @@ _comp_cmd_smartctl__drivedb()
     _comp_compgen_filedir h && [[ $prefix ]] &&
         _comp_compgen -Rv COMPREPLY -- -P "$prefix" -W '"${COMPREPLY[@]}"'
 }
+_comp_cmd_smartctl__vendorattribute()
+{
+    case $cur in
+        [1-9N],* | [1-9][0-9],* | 1[0-9][0-9],* | 2[0-4][0-9],* | 25[0-5],*)
+            # TODO: add 'raw16(raw16)', 'raw16(avg16)' and 'raw24(raw8)'.
+            # Excluded for now because 'compopt -o fullquote' (Bash >= 5.3)
+            # or similar bash_completion functionality would be required.
+            _comp_compgen -P "${cur%%,*}," -- -W 'raw{8,16,48,56,64}
+                hex{48,56,64} raw24/raw{24,32} msec24hour32
+                {sec,min,halfmin}2hour temp{10x,minmax}'
+            if ((${#COMPREPLY[@]} == 1)); then
+                _comp_compgen -R -- -W '"$COMPREPLY"{,\,,:}'
+            fi
+            ;;
+        [1-9] | [1-9][0-9] | 1[0-9][0-9] | 2[0-4][0-9] | 25[0-5])
+            _comp_compgen -- -W '{1..255},'
+            ;;
+        *)
+            _comp_compgen -- -W 'N, help'
+            ;;
+    esac
+    compopt -o nospace
+}
+_comp_cmd_smartctl__set()
+{
+    _comp_compgen -- -W 'aam,{,off} apm,{,off} dsn,{on,off}
+        lookahead,{on,off} rcache,{on,off} security-freeze standby,{,off,now}
+        wcache,{on,off} wcache-sct,{ata,on,off}{,\,p}
+        wcreorder,{on,off}{,\,p} '"$1"
+    _comp_cmd_smartctl__set_nospace_if_incomplete
+}
 
 _comp_cmd_smartctl()
 {
     local cur prev words cword was_split comp_args
     _comp_initialize -s -- "$@" || return
 
-    local noargopts='!(-*|*[qdTbrnsoSlvFPBt]*)'
+    local noargopts='!(-*|*[qdTbrnoSlvFPBtfgs]*)'
     # shellcheck disable=SC2254
     case $prev in
         --quietmode | -${noargopts}q)
@@ -64,32 +129,34 @@ _comp_cmd_smartctl()
             return
             ;;
         --report | -${noargopts}r)
-            _comp_compgen -- -W 'ioctl ataioctl scsiioctl'
+            _comp_compgen -- -W '{,ata,scsi,nvme}ioctl{,\,2}'
             return
             ;;
         --nocheck | -${noargopts}n)
-            _comp_compgen -- -W 'never sleep standby idle'
+            _comp_compgen -- -W 'never sleep{,\,} standby{,\,} idle{,\,}'
+            _comp_cmd_smartctl__set_nospace_if_incomplete
             return
             ;;
-        --smart | --offlineauto | --saveauto | -${noargopts}[soS])
+        --smart | --offlineauto | --saveauto | -${noargopts}[oS])
             _comp_compgen -- -W 'on off'
             return
             ;;
         --log | -${noargopts}l)
-            _comp_compgen -- -W 'error selftest selective directory background
-                sasphy sasphy,reset sataphy sataphy,reset scttemp scttempsts
-                scttemphist scterc gplog smartlog xerror xselftest'
+            _comp_compgen -- -W 'background defects{,\,} devstat{,\,}
+                directory{,\,g,\,s} envrep error farm genstats gplog, nvmelog,
+                sasphy{,\,reset} sataphy{,\,reset} scterc{,\,,\,p,\,reset}
+                scttemp{,sts,int\,,hist} selective selftest smartlog, ssd
+                tapealert tapedevstat xerror{,\,,\,error}
+                xselftest{,\,,\,selftest} zdevstat'
+            _comp_cmd_smartctl__set_nospace_if_incomplete
             return
             ;;
         --vendorattribute | -${noargopts}v)
-            _comp_compgen -- -W 'help 9,minutes 9,seconds 9,halfminutes 9,temp
-                192,emergencyretractcyclect 193,loadunload 194,10xCelsius
-                194,unknown 198,offlinescanuncsectorct 200,writeerrorcount
-                201,detectedtacount 220,temp'
+            _comp_cmd_smartctl__vendorattribute
             return
             ;;
         --firmwarebug | -${noargopts}F)
-            _comp_compgen -- -W 'none samsung samsung2 samsung3 swapid'
+            _comp_compgen -- -W 'none nologdir samsung{,2,3} swapid xerrorlba'
             return
             ;;
         --presets | -${noargopts}P)
@@ -101,7 +168,26 @@ _comp_cmd_smartctl()
             return
             ;;
         --test | -${noargopts}t)
-            _comp_cmd_smartctl__test
+            _comp_compgen -- -W 'afterselect,{on,off} conveyance force long
+                offline pending, scttempint, select,{,redo,next} short vendor,'
+            _comp_cmd_smartctl__set_nospace_if_incomplete
+            return
+            ;;
+        --format | -${noargopts}f)
+            _comp_compgen -- -W 'brief hex{,\,id,\,val} old'
+            return
+            ;;
+        --get | -${noargopts}g)
+            _comp_compgen -- -W 'aam all apm dsn lookahead rcache security
+                wcache{,-sct} wcreorder'
+            return
+            ;;
+        --set)
+            _comp_cmd_smartctl__set ''
+            return
+            ;;
+        -${noargopts}s) # -s {on,off}: --smart {on,off}; -s OTHER: --set OTHER
+            _comp_cmd_smartctl__set 'on off'
             return
             ;;
     esac
@@ -110,7 +196,7 @@ _comp_cmd_smartctl()
 
     if [[ $cur == -* ]]; then
         _comp_compgen_help
-        [[ ${COMPREPLY-} == *= ]] && compopt -o nospace
+        _comp_cmd_smartctl__set_nospace_if_incomplete
     else
         _comp_compgen -c "${cur:-/dev/}" filedir
     fi