Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding score-compose provisioners command in cli #161

Conversation

lekaf974
Copy link
Contributor

@lekaf974 lekaf974 commented Feb 28, 2025

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What is the motivation?

Working on a new subcommand in score compose and added the documentation accordingly to the changes

What does this change do?

N/A

What is your testing strategy?

Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.

Is this related to any issues?

If this pull request is related to any other pull request or issue, or resolves any issues - then link all related pull requests and issues here.

related to score-spec/score-compose#252 that need to be merged first

Have you read the Contributing Guidelines?

@lekaf974
Copy link
Contributor Author

lekaf974 commented Mar 1, 2025

@mathieu-benoit @astromechza this can be reviewed now

@mathieu-benoit
Copy link
Contributor

mathieu-benoit commented Mar 1, 2025

@lekaf974, there is some CI issues to resolve:

from /home/runner/work/docs/docs/content/en/docs/score implementation/score-compose/cli.md:
306 306| 
307 307| #####·Flags
308 308| 
    309|-######·--format·|·-f·
309    |+######·--format·|·-f
310 310| 
    311|-Display·listed·provisioners·in·the·format·provided.·Uses··`table`·as·default·value.·Allowed·values:·`table`,·`json`
311    |+Display·listed·provisioners·in·the·format·provided.·Uses·`table`·as·default·value.·Allowed·values:·`table`,·`json`

Once fixed, we could merge this as the new feature is now released too: https://github.com/score-spec/score-compose/releases/tag/0.25.0.

Signed-off-by: lekaf974 <[email protected]>
@lekaf974
Copy link
Contributor Author

lekaf974 commented Mar 1, 2025

fix pushed, should be good now

@mathieu-benoit mathieu-benoit self-requested a review March 1, 2025 23:10
Copy link
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mathieu-benoit mathieu-benoit merged commit 3ff7963 into score-spec:main Mar 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants