Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update cli documentation for score-compore resources list #162

Conversation

lekaf974
Copy link
Contributor

@lekaf974 lekaf974 commented Mar 2, 2025

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What is the motivation?

New flag has been added in score-compose resources list

What does this change do?

Update cli documentation for score-compore resources list with new output format flag

can be merged after score-spec/score-compose#267

What is your testing strategy?

Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.

Is this related to any issues?

If this pull request is related to any other pull request or issue, or resolves any issues - then link all related pull requests and issues here.

Have you read the Contributing Guidelines?

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
… new output format flag

Signed-off-by: lekaf974 <[email protected]>
@lekaf974
Copy link
Contributor Author

lekaf974 commented Mar 4, 2025

@mathieu-benoit this one should be good to merge now

@@ -256,6 +256,16 @@ Lists the unique identifiers (UIDs) of all provisioned resources.
score-compose resources list
```

##### Flags

###### --format | -f
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
###### --format | -f
###### `--format` | `-f`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for provisioners list on this page too please.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: lekaf974 <[email protected]>
@lekaf974 lekaf974 requested a review from mathieu-benoit March 5, 2025 01:48
Signed-off-by: lekaf974 <[email protected]>
@mathieu-benoit mathieu-benoit self-requested a review March 5, 2025 18:24
Copy link
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mathieu-benoit mathieu-benoit merged commit a7fd948 into score-spec:main Mar 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants