Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added initialization from remote origin in Electron app to resolve the error #174

Closed
wants to merge 44 commits into from

Conversation

nsginx
Copy link

@nsginx nsginx commented Jan 3, 2024

Description

Added a remoteMain in main.js and initialized it. So the issue which was arising while running the electron app is now resolved.

image

no issue is visible now.

image

the previous error is removed

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

it was a project initialisation error.

Also, include screenshots for verification and reviewing purpose.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

abdullahranginwala and others added 30 commits March 20, 2023 20:42
* Added undo/redo feature

* Added image download button

* Added image-download button

* Fixed branch conflicts
* npm package version changed

* npm installation bug fixed

Co-authored-by: = <=>
Added functionality for adaptive thresholding
* added save and load workspace feature

* removed extra workspace ref
@abdullahranginwala
Copy link
Contributor

@nazmus-saqib008 Why does this PR have 44 commits? Can you please rectify the merge conflicts?

@nsginx
Copy link
Author

nsginx commented Jan 5, 2024

@abdullahranginwala i'm also surprised. is it because of pr to development branch? should i change it to master ?

@nsginx nsginx closed this by deleting the head repository Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants