Freeze string literals in AutoInstrument layer #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think if you have a lot of AutoInstrumentation going on, this results in a lot of repeated memory allocations for the same string.
'AutoInstrument' is used in a comparison here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think if you have a lot of AutoInstrumentation going on, this results in a lot of repeated memory allocations for the same string.
Addresses #495
I tested this out in our staging environment and it does remove the string allocations from strings in these files. I don't know if this is meaningful at all or if it's worth doing it piecemeal like this, versus just adding the pragma to everything or relying on the user to pass some Ruby options to freeze all string literals.