Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Good job Integration #506

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

benngarcia
Copy link
Contributor

Add GoodJob Integration

Since this GoodJob integration is utilizing the around_perform action (like the que integration), you can likely reuse this integration for SolidQueue as well.

@lancetarn
Copy link
Contributor

What a gift! We will take a harder look at this shortly.

@benngarcia benngarcia changed the title Good job Integration [WIP] Good job Integration Aug 7, 2024
@benngarcia
Copy link
Contributor Author

Currently testing in our production setup and not quite working 😅.

Consider a WIP :)

@benngarcia benngarcia changed the title [WIP] Good job Integration Good job Integration Aug 7, 2024
@benngarcia
Copy link
Contributor Author

It's all good now! The only thing specific to GoodJob is detection everything else is based off ActiveJob 👍

@lancetarn lancetarn merged commit efc5cbc into scoutapp:master Sep 6, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants