Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anchor and subpath for relative links #22

Merged
merged 11 commits into from
Sep 11, 2024
Merged

Fix anchor and subpath for relative links #22

merged 11 commits into from
Sep 11, 2024

Conversation

Zokhoi
Copy link
Contributor

@Zokhoi Zokhoi commented Sep 9, 2024

src/url.rs Show resolved Hide resolved
@Zokhoi
Copy link
Contributor Author

Zokhoi commented Sep 10, 2024

Added parsing of internal links into page segment and extra segment.

Links starting with / is currently treated as LinkLocation::Url, and fixing this is out of scope for this particular PR.

Copy link
Member

@emmiegit emmiegit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the good work, couple more comments.

src/tree/link.rs Outdated Show resolved Hide resolved
src/tree/link.rs Show resolved Hide resolved
src/tree/link.rs Show resolved Hide resolved
src/tree/link.rs Show resolved Hide resolved
src/tree/link.rs Show resolved Hide resolved
@emmiegit
Copy link
Member

LGTM

@Zokhoi Zokhoi merged commit fbb51e0 into main Sep 11, 2024
6 checks passed
@Zokhoi Zokhoi deleted the rel-link-fix branch September 11, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants