Skip to content

Commit

Permalink
chore: remove pylama/pydocstyle, just use pylint
Browse files Browse the repository at this point in the history
  • Loading branch information
carlmontanari committed Aug 9, 2024
1 parent 8f56147 commit 2e8db37
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 17 deletions.
4 changes: 3 additions & 1 deletion .pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ confidence=HIGH,
# --enable=similarities". If you want to run only the classes checker, but have
# no Warning level messages displayed, use "--disable=all --enable=classes
# --disable=W".
disable=C0103,C0115,R0901,R0902,R0903,R0913,R0914,W1202,W1203
disable=C0103,C0115,R0401,R0801,R0901,R0902,R0903,R0913,R0914,W1202,W1203
# C0103 = constant-name (a little too aggressive for some things that aren't "really" constants")
# C0115 = class docstrings (init doc strings cover this already)
# W1202 = use % formatting for logging (ignore, using f-strings)
Expand All @@ -153,6 +153,8 @@ disable=C0103,C0115,R0901,R0902,R0903,R0913,R0914,W1202,W1203
# R0903 = too-few-public methods
# R0913 = too-many-arguments
# R0914 = too-many-local-variables
# R0801 = similar-lines
# R0401 = cyclic-import (too many false positives, seems like this is a common complaint :p)

# Enable the message, report, category or checker with the given id(s). You can
# either give multiple identifier separated by comma (,) or put this option
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
lint:
python -m isort .
python -m black .
python -m pylama .
python -m pylint scrapli_netconf/
python -m pydocstyle .
python -m mypy --strict scrapli_netconf/

Expand Down
6 changes: 3 additions & 3 deletions noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,9 +156,9 @@ def black(session):


@nox.session(python=["3.11"])
def pylama(session):
def pylint(session):
"""
Nox run pylama
Nox run pylint
Args:
session: nox session
Expand All @@ -171,7 +171,7 @@ def pylama(session):
"""
session.install(*_get_install_test_args())
session.run("python", "-m", "pylama", ".")
session.run("python", "-m", "pylint", "scrapli_netconf/")


@nox.session(python=["3.11"])
Expand Down
10 changes: 0 additions & 10 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -114,16 +114,6 @@ warn_unused_configs = true
strict_optional = true


[tool.pylama]
linters = "mccabe,pycodestyle,pylint"
skip = ".nox/*,.private/*,build/*,docs/*,private/*,site/*,tests/*,venv/*"

[tool.pylama.pycodestyle]
max_line_length = 100

[tool.pylama.pylint]
rcfile = ".pylintrc"

[tool.pydocstyle]
match-dir = "^scrapli_netconf/*"
ignore = "D101,D202,D203,D212,D400,D406,D407,D408,D409,D415"
Expand Down
2 changes: 0 additions & 2 deletions requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@ darglint>=1.8.1,<2.0.0
isort>=5.10.1,<6.0.0
mypy>=1.4.1,<2.0.0
nox==2024.4.15
pycodestyle>=2.8.0,<3.0.0
pydocstyle>=6.1.1,<7.0.0
pylama>=8.4.0,<9.0.0
pylint>=3.0.0,<4.0.0
pytest-asyncio>=0.17.0,<1.0.0
pytest-cov>=3.0.0,<5.0.0
Expand Down

0 comments on commit 2e8db37

Please sign in to comment.