fix: always close transport if onopen funcs (or netconf capabilities …

…things) error

driver/generic/driver.go

@@ -100,6 +100,10 @@ func (d *Driver) Open() error {
 		if err != nil {
 			d.Logger.Criticalf("error executing generic driver OnOpen, error: %s", err)
 
+			// don't leave the channel (and more importantly, the transport) open if we are going to
+			// return an error
+			_ = d.Channel.Close()
+
 			return err
 		}
 	}

driver/netconf/driver.go

@@ -206,7 +206,7 @@ type Driver struct {
 
 // Open opens the underlying generic.Driver, and by extension the channel.Channel and Transport
 // objects. This should be called prior to executing any RPC methods of the Driver.
-func (d *Driver) Open() error {
+func (d *Driver) Open() (reterr error) {
 	d.Logger.Debugf(
 		"opening connection to host '%s' on port '%d'",
 		d.Transport.Args.Host,
@@ -218,6 +218,14 @@ func (d *Driver) Open() error {
 		return err
 	}
 
+	defer func() {
+		if reterr != nil {
+			// don't leave the channel (and more importantly, the transport) open if we are going to
+			// return an error
+			_ = d.Channel.Close()
+		}
+	}()
+
 	err = d.processServerCapabilities()
 	if err != nil {
 		return err

driver/network/driver.go

@@ -82,6 +82,10 @@ func (d *Driver) Open() error {
 		if err != nil {
 			d.Logger.Criticalf("error executing network driver OnOpen, error: %s", err)
 
+			// don't leave the channel (and more importantly, the transport) open if we are going to
+			// return an error
+			_ = d.Channel.Close()
+
 			return err
 		}
 	}