Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JobPosting support to the provider. #159

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Add JobPosting support to the provider. #159

merged 2 commits into from
Jan 11, 2024

Conversation

wRAR
Copy link
Contributor

@wRAR wRAR commented Jan 5, 2024 •
edited
Loading

Fixes #158

  • Test against the real server

@wRAR wRAR requested review from kmike and Gallaecio January 5, 2024 14:01
@codecov Codecov
Copy link

codecov bot commented Jan 5, 2024 •
edited
Loading

Codecov Report

Merging #159 (c1fbc86) into main (789867b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files          11       11           
  Lines         812      812           
=======================================
  Hits          801      801           
  Misses         11       11
Files Coverage Δ
scrapy_zyte_api/providers.py 96.77% <ø> (ø)

kmike
kmike approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@kmike kmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to merge after it's tested against real server

@wRAR wRAR merged commit d45c4cf into main Jan 11, 2024
19 checks passed
@wRAR wRAR deleted the job-posting branch January 11, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmike kmike kmike approved these changes

@Gallaecio Gallaecio Awaiting requested review from Gallaecio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add JobPosting to the provider
2 participants
@wRAR @kmike