Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling for Zyte API #123

Merged
merged 13 commits into from
Aug 2, 2024
Merged

Conversation

Gallaecio
Copy link
Contributor

@Gallaecio Gallaecio commented Jul 23, 2024

  • Treat 429 and 503 responses with a Zyte-Error header the same as noslaves 503 responses from Smart Proxy Manager.
  • Treat 520 and 521 responses with a Zyte-Error header the same as banned 503 responses from Smart Proxy Manager.
  • CI stuff:
    • Move bandit to pre-commit as part of silencing errors about assert use
    • Add a mypy job, since mypy is the reason why we allow asserts in code
    • Remove Python 3.5 from CI for technical reasons; we continue to test 3.4, though.
    • Use caching to speed up Python < 3.8 jobs.

cc @janin @neoyogi @BurnzZ @PyExplorer

@Gallaecio Gallaecio changed the title Use exponential backoff for 429 from Zyte Improve error handling for Zyte API Aug 2, 2024
@Gallaecio Gallaecio requested review from kmike and geronsv August 2, 2024 04:37
@Gallaecio Gallaecio merged commit 0fb96a6 into scrapy-plugins:master Aug 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants