Skip to content

Remove redundant code and fix pylint #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 15, 2021
Merged

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Nov 9, 2021

EOL Python 2.7 and 3.5 were dropped in #168 so we can remove some redundant code and upgrade
upgrade Python syntax with https://github.com/asottile/pyupgrade --py36-plus.

Also add python_requires to help pip and fix some deprecation warnings.

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #175 (bf2c90e) into master (2d76c99) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   95.68%   95.68%   -0.01%     
==========================================
  Files           7        7              
  Lines         464      463       -1     
  Branches       88       88              
==========================================
- Hits          444      443       -1     
  Misses         10       10              
  Partials       10       10              
Impacted Files Coverage Δ
w3lib/encoding.py 98.66% <100.00%> (-0.02%) ⬇️
w3lib/html.py 95.45% <100.00%> (ø)
w3lib/http.py 100.00% <100.00%> (ø)
w3lib/url.py 98.02% <100.00%> (ø)

@Gallaecio Gallaecio merged commit 8e69489 into scrapy:master Nov 15, 2021
@hugovk hugovk deleted the rm-eol branch November 15, 2021 07:39
@kmike kmike added this to the 2.0.0 milestone Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants