fix(deps): update dompurify to v3.2.6 and fix associated tests #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous versions of dompurify changed SVG attribute order as a side effect. This new version does not. The tests should probably ignore attribute order, but for now I've just corrected it to match.
MiroslavDionisiev
approved these changes
May 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Proposed Changes
dompurifyto version 3.2.6tests/fixtures/*.sanitized.svgto matchReason for Changes
Previous versions of dompurify changed SVG attribute order as a side effect. This new version does not. The tests would ideally ignore attribute order, but for now, I've just corrected it to match.
Test Coverage
Covered 👍