feat(3161): Add support to allow remote triggers for a stage #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar1312
force-pushed
the
sagar1312-feat-3161-remote_trigger_for_stage
branch
from
a4de9e7 to
9972660
Compare
tkyi
reviewed
Aug 2, 2024
tkyi
reviewed
Aug 2, 2024
config/regex.js
Outdated
| // External trigger like sd@123:component (AND case) | ||
| EXTERNAL_TRIGGER_AND: /^sd@(\d+):([\w-]+)$/, | ||
| // External trigger like ~sd@123:component, ~sd@26:stage@alpha:setup (OR case) | ||
| EXTERNAL_TRIGGER: /^~sd@(\d+):(([\w-]+)|(stage@([\w-]+):setup))$/, |
There was a problem hiding this comment.
Suggested change
| EXTERNAL_TRIGGER: /^~sd@(\d+):(([\w-]+)|(stage@([\w-]+):setup))$/, | |
| EXTERNAL_TRIGGER: /^~sd@(\d+):(?:([\w-]+)|(stage@([\w-]+):setup))$/, |
Before:
After:
tkyi
reviewed
Aug 2, 2024
config/regex.js
Outdated
| // External trigger like ~sd@123:component, ~sd@26:stage@alpha:setup (OR case) | ||
| EXTERNAL_TRIGGER: /^~sd@(\d+):(([\w-]+)|(stage@([\w-]+):setup))$/, | ||
| // External trigger like sd@123:component, sd@26:stage@alpha:setup (AND case) | ||
| EXTERNAL_TRIGGER_AND: /^sd@(\d+):(([\w-]+)|(stage@([\w-]+):setup))$/, |
There was a problem hiding this comment.
Suggested change
| EXTERNAL_TRIGGER_AND: /^sd@(\d+):(([\w-]+)|(stage@([\w-]+):setup))$/, | |
| EXTERNAL_TRIGGER_AND: /^sd@(\d+):(?:([\w-]+)|(stage@([\w-]+):setup))$/, |
same idea as above
tkyi
reviewed
Aug 2, 2024
config/regex.js
Outdated
| // External trigger (OR and AND case) | ||
| // Can be ~sd@123:component or sd@123:component | ||
| EXTERNAL_TRIGGER_ALL: /^~?sd@(\d+):([\w-]+)$/, | ||
| EXTERNAL_TRIGGER_ALL: /^~?sd@(\d+):(([\w-]+)|(stage@([\w-]+):setup))$/, |
There was a problem hiding this comment.
Suggested change
| EXTERNAL_TRIGGER_ALL: /^~?sd@(\d+):(([\w-]+)|(stage@([\w-]+):setup))$/, | |
| EXTERNAL_TRIGGER_ALL: /^~?sd@(\d+):(?:([\w-]+)|(stage@([\w-]+):setup))$/, |
same idea as above
sagar1312
force-pushed
the
sagar1312-feat-3161-remote_trigger_for_stage
branch
from
9972660 to
ff0dbeb
Compare
sagar1312
force-pushed
the
sagar1312-feat-3161-remote_trigger_for_stage
branch
from
ff0dbeb to
e7b7bd9
Compare
sagar1312
force-pushed
the
sagar1312-feat-3161-remote_trigger_for_stage
branch
from
0c57ad3 to
a6fe71f
Compare
tkyi
approved these changes
Aug 5, 2024
|
🎉 This PR is included in version 23.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently a stage can have only the jobs within the same pipeline as its upstream. Because of this limitation, a stage cannot be triggered from a remote pipeline.
Objective
Allow stages to have jobs (Ex:
sd@123:remote-job) from remote pipeline to be configured as its upstream.References
screwdriver-cd/screwdriver#3161
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.