fix: no lodash for cloning (#3111)

Co-authored-by: Ming-Hay <[email protected]>
screwdriver-cd · May 7, 2024 · ac35b12 · ac35b12
1 parent 0782760
commit ac35b12
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -93,7 +93,6 @@
     "js-yaml": "^3.14.1",
     "jsonwebtoken": "^9.0.0",
     "license-checker": "^25.0.1",
-    "lodash": "^4.17.21",
     "lodash.mergewith": "^4.6.2",
     "ndjson": "^2.0.0",
     "node-env-file": "^0.1.8",

diff --git a/test/plugins/webhooks.helper.test.js b/test/plugins/webhooks.helper.test.js
@@ -5,7 +5,6 @@ const sinon = require('sinon');
 const rewire = require('rewire');
 const { assert } = chai;
 const hoek = require('@hapi/hoek');
-const _ = require('lodash');
 
 chai.use(require('chai-as-promised'));
 
@@ -1436,7 +1435,7 @@ describe('startHookEvent test', () => {
                         branch: Promise.resolve('master')
                     })
                 ]);
-            const pipelineMock2 = _.cloneDeep(pipelineMock);
+            const pipelineMock2 = Object.assign({}, pipelineMock);
 
             pipelineMock2.subscribedScmUrlsWithActions = [{ scmUri: 'github.com:789123:master', actions: ['commit'] }];
             pipelineFactoryMock.list
@@ -2009,7 +2008,7 @@ describe('startHookEvent test', () => {
                             branch: Promise.resolve('master')
                         })
                     ]);
-                const pipelineMock2 = _.cloneDeep(pipelineMock);
+                const pipelineMock2 = Object.assign({}, pipelineMock);
 
                 pipelineMock2.subscribedScmUrlsWithActions = [{ scmUri: 'github.com:789123:master', actions: ['pr'] }];
                 pipelineFactoryMock.list