feat(3124): Add validatePipelineTemplate function [2] #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkyi
force-pushed
the
validatePipelineTemplate
branch
from
ac6fe7b to
a865bab
Compare
pritamstyz4ever
previously approved these changes
Jun 11, 2024
|
|
||
| templateFactoryMock.getTemplate.resolves(template); | ||
| // eslint-disable-next-line global-require | ||
| validator = require('../index').validatePipelineTemplate; |
There was a problem hiding this comment.
validatePipelineTemplate: validateTemplate
I think the variable is renamed to validateTemplate.
tkyi
force-pushed
the
validatePipelineTemplate
branch
from
a865bab to
26e8870
Compare
tkyi
force-pushed
the
validatePipelineTemplate
branch
from
26e8870 to
59dff91
Compare
pritamstyz4ever
approved these changes
Jun 13, 2024
|
🎉 This PR is included in version 8.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The is displaying only the configurations stored in the database without extending the job template. It would be nice if it would merge template steps if the pipeline template is using a template.
Objective
This PR adds a new function for pipeline template validator to show users flattened job template steps.
References
Related to screwdriver-cd/screwdriver#3124
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.