feat(3240): Event Landing View & Job List View - Visually differentiate virtual job from normal job #1229
Conversation
|
For the fast forward icon, should it be in a circle too for consistency? |
| @@ -93,6 +157,26 @@ module('Integration | Component | pipeline list job cell', function (hooks) { | |||
| assert.dom('.job-name').hasText('b'); | |||
| }); | |||
|
|
|||
| test('it renders a failed build for virtual job', async function (assert) { | |||
There was a problem hiding this comment.
would this show up as a red fastforward icon?
sagar1312
force-pushed
the
sagar1312-feat-3240-virtual_jobs
branch
from
778a85f to
b917191
Compare
Initially looked for an fast-forward icon inside a circle. We don't have one with the circle border in the font library we are using https://fontawesome.com/v4/icons/ Also when the build is frozen, we use snowflake icon which is not enclosed with in a circle |
|
Hm in the workflowGraph in the main area and in the events list it looks enclosed, but it's not for the overall status in the events list |
…te virtual job from normal job
But, we don't have fast-forward icon inside a circle. For now, we can go with the one with out the circle border. |
sagar1312
force-pushed
the
sagar1312-feat-3240-virtual_jobs
branch
from
b917191 to
c3420b1
Compare
Context
Builds for virtual jobs are not executed in a event. In the UI, such builds are not easily distinguishable from non-virtual job builds.
Objective
References
screwdriver-cd/screwdriver#3240
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.