fix(3253): allow time range picker to render based on correct input selection #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minghay
requested changes
Dec 16, 2024
| } else { | ||
| this.onTimeRangeChange(); | ||
| } | ||
| }, | ||
| setCustomRange([start, end]) { | ||
| this.set('selectedRange'); | ||
| this.set('selectedRange', 'none'); |
There was a problem hiding this comment.
setCustomRange should account for a non-date range selection by not changing the selectedRange instead of setting the value to none. By doing that, closing the date picker will not force an unnecessary reload of the page.
| @@ -46,13 +61,13 @@ export default Component.extend({ | |||
| if (range) { | |||
| const { startTime, endTime } = timeRange(new Date(), range); | |||
|
|
|||
| this.onTimeRangeChange(startTime, endTime); | |||
| this.onTimeRangeChange(startTime, endTime, this.selectedRange); | |||
| } else { | |||
| this.onTimeRangeChange(); | |||
| } | |||
| }, | |||
There was a problem hiding this comment.
setTimeRange can be simplified because the template has the button group configured as radio buttons which will prevent the setTimeRange from executing unless a different radio button selection is selected.
VonnyJap
force-pushed
the
template-timepicker-fix-1
branch
from
5bcd0f4 to
77f3cff
Compare
minghay
previously approved these changes
Dec 19, 2024
VonnyJap
force-pushed
the
template-timepicker-fix-1
branch
from
005d0a8 to
69b07ae
Compare
minghay
reviewed
Dec 20, 2024
Co-authored-by: Ming-Hay <[email protected]>
Co-authored-by: Ming-Hay <[email protected]>
Co-authored-by: Ming-Hay <[email protected]>
Co-authored-by: Ming-Hay <[email protected]>
minghay
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, when users select a time range in the job template view, the dropdown always defaults to "1 yr" instead of retaining the selected time range. This behavior results in a poor user experience, as the time range is not properly applied or displayed according to user input.
Objective
The goal of this PR is to fix the time range selection behavior in the job template view. The time range dropdown should accurately display and apply the user's selected value, ensuring that the selection is preserved and reflected correctly in the UI.
Screen.Recording.2024-12-19.at.2.13.52.PM.mov
References
screwdriver-cd/screwdriver#3253
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.