Fixed memory leaks

scribeocr · Oct 31, 2024 · 20d39c8 · 20d39c8
1 parent 92ec67b
commit 20d39c8
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 2 deletions.
diff --git a/js/containers/imageContainer.js b/js/containers/imageContainer.js
@@ -196,6 +196,9 @@ export class ImageCache {
 
     const workersPromiseArr = range(0, scheduler.workers.length - 1).map(async (x) => {
       const w = scheduler.workers[x];
+
+      if (w.pdfDoc) await w.freeDocument(w.pdfDoc);
+
       // The ArrayBuffer is transferred to the worker, so a new one must be created for each worker.
       // const fileData = await file.arrayBuffer();
       const fileDataCopy = fileData.slice(0);

diff --git a/js/export/export.js b/js/export/export.js
@@ -143,6 +143,8 @@ export async function exportData(format = 'txt', minValue = 0, maxValue = -1) {
           doc1: pdfOverlay, minpage: minValue, maxpage: maxValue, pagewidth: dimsLimit.width, pageheight: dimsLimit.height, humanReadable: opt.humanReadablePDF,
         });
       }
+
+      w.freeDocument(pdfOverlay);
     } else {
       const pdfStr = await writePdf(ocrDownload, minValue, maxValue, opt.displayMode, false, true, dimsLimit, opt.confThreshHigh, opt.confThreshMed,
         opt.overlayOpacity / 100);
@@ -169,6 +171,8 @@ export async function exportData(format = 'txt', minValue = 0, maxValue = -1) {
       content = await w.write({
         doc1: pdf, minpage: minValue, maxpage: maxValue, pagewidth: dimsLimit.width, pageheight: dimsLimit.height, humanReadable: opt.humanReadablePDF,
       });
+
+      w.freeDocument(pdf);
     }
   } else if (format === 'hocr') {
     content = writeHocr(ocrAll.active, minValue, maxValue);

diff --git a/mupdf/mupdf-async.js b/mupdf/mupdf-async.js
@@ -90,7 +90,7 @@ export async function initMuPDFWorker() {
     return function (...args) {
       return new Promise((resolve, reject) => {
         // Add the PDF as the first argument for most functions
-        if (!['openDocument', 'cleanFile'].includes(func)) {
+        if (!['openDocument', 'cleanFile', 'freeDocument'].includes(func)) {
           // Remove job number (appended by Tesseract scheduler function)
           // args = args.slice(0,-1)
 

diff --git a/mupdf/mupdf-worker.js b/mupdf/mupdf-worker.js
@@ -165,6 +165,8 @@ mupdf.pageText = function (doc, {
 
   const content = Module.UTF8ToString(dataPtr);
 
+  Module._free(dataPtr);
+
   return {
     letterCountTotal,
     letterCountVis,
@@ -464,7 +466,7 @@ const handleMessage = (data) => {
   } catch (error) {
     parentPort.postMessage(['ERROR', id, { name: error.name, message: error.message }]);
   }
-}
+};
 
 if (typeof process === 'undefined') {
   onmessage = (event) => handleMessage(event.data);