Merge remote-tracking branch 'origin/master' #131
Clippy Output
17 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 17 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.83.0-nightly (fa724e5d8 2024-09-27)
- cargo 1.83.0-nightly (eaee77dc1 2024-09-19)
- clippy 0.1.83 (fa724e5 2024-09-27)
Annotations
Check warning on line 10 in scripty_webserver/src/auth.rs
github-actions / Clippy Output
field `token` is never read
warning: field `token` is never read
--> scripty_webserver/src/auth.rs:10:6
|
8 | pub struct Authentication {
| -------------- field in this struct
9 | /// The token used for auth.
10 | pub token: String,
| ^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 168 in scripty_bot_utils/src/entity_block.rs
github-actions / Clippy Output
this function depends on never type fallback being `()`
warning: this function depends on never type fallback being `()`
--> scripty_bot_utils/src/entity_block.rs:168:1
|
168 | pub async fn add_blocked_guild(guild_id: GuildId, reason: Option<String>) -> Result<(), Error> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #123748 <https://github.com/rust-lang/rust/issues/123748>
= help: specify the types explicitly
note: in edition 2024, the requirement `!: scripty_redis::redis::FromRedisValue` will fail
--> scripty_bot_utils/src/entity_block.rs:185:4
|
185 | .set(
| ^^^
Check warning on line 138 in scripty_bot_utils/src/entity_block.rs
github-actions / Clippy Output
this function depends on never type fallback being `()`
warning: this function depends on never type fallback being `()`
--> scripty_bot_utils/src/entity_block.rs:138:1
|
138 | pub async fn add_blocked_user(user_id: UserId, reason: Option<String>) -> Result<(), Error> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #123748 <https://github.com/rust-lang/rust/issues/123748>
= help: specify the types explicitly
note: in edition 2024, the requirement `!: scripty_redis::redis::FromRedisValue` will fail
--> scripty_bot_utils/src/entity_block.rs:155:4
|
155 | .set(
| ^^^
Check warning on line 8 in scripty_bot_utils/src/entity_block.rs
github-actions / Clippy Output
this function depends on never type fallback being `()`
warning: this function depends on never type fallback being `()`
--> scripty_bot_utils/src/entity_block.rs:8:1
|
8 | pub async fn init_blocked() -> Result<(), scripty_redis::redis::RedisError> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #123748 <https://github.com/rust-lang/rust/issues/123748>
= help: specify the types explicitly
note: in edition 2024, the requirement `!: scripty_redis::redis::FromRedisValue` will fail
--> scripty_bot_utils/src/entity_block.rs:34:5
|
34 | .query_async(&mut redis_pool)
| ^^^^^^^^^^^
= note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default
Check warning on line 28 in scripty_audio_handler/src/events/driver_disconnect.rs
github-actions / Clippy Output
this function has too many arguments (10/7)
warning: this function has too many arguments (10/7)
--> scripty_audio_handler/src/events/driver_disconnect.rs:17:1
|
17 | / pub async fn driver_disconnect(
18 | | guild_id: GuildId,
19 | | reason: Option<DisconnectReason>,
20 | | ctx: Context,
... |
27 | | ephemeral: bool,
28 | | ) {
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
Check warning on line 89 in scripty_audio_handler/src/audio_handler.rs
github-actions / Clippy Output
this function has too many arguments (10/7)
warning: this function has too many arguments (10/7)
--> scripty_audio_handler/src/audio_handler.rs:78:2
|
78 | / pub async fn new(
79 | | guild_id: GuildId,
80 | | webhook: Webhook,
81 | | context: Context,
... |
88 | | ephemeral: bool,
89 | | ) -> Result<Self, Error> {
| |____________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
Check warning on line 148 in scripty_audio_handler/src/events/voice_tick.rs
github-actions / Clippy Output
unused variable: `auto_detect_lang`
warning: unused variable: `auto_detect_lang`
--> scripty_audio_handler/src/events/voice_tick.rs:148:3
|
148 | auto_detect_lang,
| ^^^^^^^^^^^^^^^^ help: try ignoring the field: `auto_detect_lang: _`
|
= note: `#[warn(unused_variables)]` on by default
Check warning on line 26 in scripty_audio_handler/src/connect.rs
github-actions / Clippy Output
this function depends on never type fallback being `()`
warning: this function depends on never type fallback being `()`
--> scripty_audio_handler/src/connect.rs:18:1
|
18 | / pub async fn connect_to_vc(
19 | | ctx: Context,
20 | | guild_id: GuildId,
21 | | channel_id: ChannelId,
... |
25 | | ephemeral: bool,
26 | | ) -> Result<(), Error> {
| |______________________^
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #123748 <https://github.com/rust-lang/rust/issues/123748>
= help: specify the types explicitly
note: in edition 2024, the requirement `!: scripty_redis::redis::FromRedisValue` will fail
--> scripty_audio_handler/src/connect.rs:119:2
|
119 | / scripty_redis::run_transaction("SET", |f| {
120 | | f.arg(format!("voice:{{{}}}:webhook_token", guild_id))
121 | | .arg(webhook_token.expose_secret())
122 | | .arg("EX")
123 | | .arg(leave_delta + 5);
124 | | })
| |______^
= note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default
Check warning on line 18 in scripty_botlists/src/common.rs
github-actions / Clippy Output
empty line after outer attribute
warning: empty line after outer attribute
--> scripty_botlists/src/common.rs:17:1
|
17 | / #[serde(transparent)]
18 | |
| |_
19 | pub struct UserId(
| ----------------- the attribute applies to this struct
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr
= note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default
= help: if the empty line is unintentional remove it
Check warning on line 9 in scripty_botlists/src/lists/disforge_com/models.rs
github-actions / Clippy Output
field `message` is never read
warning: field `message` is never read
--> scripty_botlists/src/lists/disforge_com/models.rs:9:6
|
7 | pub struct PostStatsResponse {
| ----------------- field in this struct
8 | pub status: String,
9 | pub message: String,
| ^^^^^^^
|
= note: `PostStatsResponse` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
Check warning on line 11 in scripty_botlists/src/lists/discordextremelist_xyz/models.rs
github-actions / Clippy Output
field `status` is never read
warning: field `status` is never read
--> scripty_botlists/src/lists/discordextremelist_xyz/models.rs:11:6
|
9 | pub struct PostStatsResponse {
| ----------------- field in this struct
10 | pub error: bool,
11 | pub status: u16,
| ^^^^^^
|
= note: `PostStatsResponse` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
Check warning on line 10 in scripty_botlists/src/lists/discord_bots_gg/models.rs
github-actions / Clippy Output
fields `code` and `message` are never read
warning: fields `code` and `message` are never read
--> scripty_botlists/src/lists/discord_bots_gg/models.rs:10:6
|
9 | pub struct PostStatsResponse {
| ----------------- fields in this struct
10 | pub code: u16,
| ^^^^
11 | pub message: String,
| ^^^^^^^
|
= note: `PostStatsResponse` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
Check warning on line 171 in scripty_i18n/src/cache.rs
github-actions / Clippy Output
first doc comment paragraph is too long
warning: first doc comment paragraph is too long
--> scripty_i18n/src/cache.rs:167:1
|
167 | / /// Set a guild's language in the cache and database.
168 | | /// It's recommended to use this over manually inserting into the database, as it checks input validity.
169 | | /// This is a guild-specific language, and is not the same as the user's language.
170 | | ///
171 | | /// # Errors
| |_
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
help: add an empty line
|
167 ~ /// Set a guild's language in the cache and database.
168 + ///
|
Check warning on line 132 in scripty_i18n/src/cache.rs
github-actions / Clippy Output
first doc comment paragraph is too long
warning: first doc comment paragraph is too long
--> scripty_i18n/src/cache.rs:130:1
|
130 | / /// Get a guild's language from the cache, falling back to a database query if not cached,
131 | | /// and if not in database, falling back to English (`en`).
132 | | /// This is a guild-specific language, and is not the same as the user's language.
| |_
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
= note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default
Check warning on line 2 in scripty_data_storage/src/cache/voice.rs
github-actions / Clippy Output
function `init_voice_cache_async` is never used
warning: function `init_voice_cache_async` is never used
--> scripty_data_storage/src/cache/voice.rs:2:14
|
2 | pub async fn init_voice_cache_async() -> Result<(), scripty_redis::redis::RedisError> {
| ^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 2 in scripty_data_storage/src/cache/voice.rs
github-actions / Clippy Output
this function depends on never type fallback being `()`
warning: this function depends on never type fallback being `()`
--> scripty_data_storage/src/cache/voice.rs:2:1
|
2 | pub async fn init_voice_cache_async() -> Result<(), scripty_redis::redis::RedisError> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #123748 <https://github.com/rust-lang/rust/issues/123748>
= help: specify the types explicitly
note: in edition 2024, the requirement `!: scripty_redis::redis::FromRedisValue` will fail
--> scripty_data_storage/src/cache/voice.rs:19:4
|
19 | .query_async(
| ^^^^^^^^^^^
= note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default
Check warning on line 82 in scripty_automod/src/types.rs
github-actions / Clippy Output
this function has too many arguments (8/7)
warning: this function has too many arguments (8/7)
--> scripty_automod/src/types.rs:73:2
|
73 | / pub fn new(
74 | | guild_id: u64,
75 | | internal_id: i32,
76 | | enabled: bool,
... |
81 | | auto_join_voice: bool,
82 | | ) -> Self {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default