Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(codecv2): add zstd compression and increase chunks num per batch post compression #2

Merged
merged 52 commits into from
May 16, 2024
Merged

feat(codecv2): add zstd compression and increase chunks num per batch post compression #2

merged 52 commits into from
May 16, 2024

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Apr 29, 2024 •
edited
Loading

Purpose or design rationale of this PR

add codecv2.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

@colinlyguo colinlyguo force-pushed the feat-add-codecv0-and-codecv1 branch from c23d2f5 to e9bd662 Compare April 29, 2024 12:13
@colinlyguo colinlyguo force-pushed the feat-codecv1-add-zstd-compression-and-increase-chunks-num-per-batch-post-compression branch 4 times, most recently from 4aaf9d3 to 9ff3d30 Compare April 29, 2024 12:44
@colinlyguo colinlyguo force-pushed the feat-add-codecv0-and-codecv1 branch from e9bd662 to bee839b Compare April 29, 2024 12:49
@colinlyguo colinlyguo force-pushed the feat-codecv1-add-zstd-compression-and-increase-chunks-num-per-batch-post-compression branch from 9ff3d30 to c9c5566 Compare April 29, 2024 12:52
@colinlyguo colinlyguo force-pushed the feat-codecv1-add-zstd-compression-and-increase-chunks-num-per-batch-post-compression branch 2 times, most recently from bfa0017 to ebfc226 Compare April 29, 2024 15:36
@colinlyguo colinlyguo force-pushed the feat-codecv1-add-zstd-compression-and-increase-chunks-num-per-batch-post-compression branch from 1f1b279 to 9ac5267 Compare April 29, 2024 15:56
@colinlyguo colinlyguo mentioned this pull request Apr 29, 2024
Closed
5 tasks
@colinlyguo colinlyguo force-pushed the feat-codecv1-add-zstd-compression-and-increase-chunks-num-per-batch-post-compression branch from e3705d3 to c6c9a79 Compare April 30, 2024 19:40
@colinlyguo colinlyguo force-pushed the feat-codecv1-add-zstd-compression-and-increase-chunks-num-per-batch-post-compression branch from c6c9a79 to 5fdc0f4 Compare April 30, 2024 19:43
@colinlyguo colinlyguo force-pushed the feat-codecv1-add-zstd-compression-and-increase-chunks-num-per-batch-post-compression branch from d1529ca to 9299133 Compare May 2, 2024 13:19
@colinlyguo colinlyguo changed the title feat(codecv1): add zstd compression and increase chunks num per batch post compression feat(codecv2): add zstd compression and increase chunks num per batch post compression May 2, 2024
Thegaram
Thegaram previously approved these changes May 5, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
encoding/codecv1/codecv1.go Outdated Show resolved Hide resolved
rs/Cargo.toml Outdated Show resolved Hide resolved
rs/libscroll_zstd.so Outdated Show resolved Hide resolved
rs/src/lib.rs Outdated Show resolved Hide resolved
encoding/codecv2/codecv2.go Show resolved Hide resolved
encoding/codecv2/codecv2.go Outdated Show resolved Hide resolved
encoding/codecv2/codecv2.go Outdated Show resolved Hide resolved
encoding/codecv2/codecv2.go Show resolved Hide resolved
encoding/codecv2/codecv2_test.go Outdated Show resolved Hide resolved
@colinlyguo colinlyguo requested a review from georgehao May 6, 2024 09:17
georgehao
georgehao previously approved these changes May 13, 2024
View reviewed changes
0xmountaintop
0xmountaintop reviewed May 13, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@colinlyguo colinlyguo force-pushed the feat-codecv1-add-zstd-compression-and-increase-chunks-num-per-batch-post-compression branch from 75d5ce7 to 6a578e0 Compare May 13, 2024 10:26
Thegaram
Thegaram previously approved these changes May 14, 2024
View reviewed changes
encoding/da.go Outdated Show resolved Hide resolved
run_test.sh Outdated Show resolved Hide resolved
run_test.sh Outdated Show resolved Hide resolved
0xmountaintop
0xmountaintop previously approved these changes May 14, 2024
View reviewed changes
Copy link

@0xmountaintop 0xmountaintop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: add github auto-release action in the future

@colinlyguo colinlyguo dismissed stale reviews from 0xmountaintop and Thegaram via 729c7fe May 15, 2024 12:53
@colinlyguo colinlyguo requested a review from 0xmountaintop May 16, 2024 11:41
@colinlyguo colinlyguo merged commit db04f5e into main May 16, 2024
3 checks passed
@colinlyguo colinlyguo deleted the feat-codecv1-add-zstd-compression-and-increase-chunks-num-per-batch-post-compression branch May 16, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmountaintop 0xmountaintop 0xmountaintop approved these changes

@Thegaram Thegaram Thegaram approved these changes

@noel2004 noel2004 Awaiting requested review from noel2004

@georgehao georgehao Awaiting requested review from georgehao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@colinlyguo @georgehao @Thegaram @noel2004 @0xmountaintop