build: require exact zstd version #56
Conversation
WalkthroughThe Changes
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
libzstd/encoder-standard/Cargo.toml (1)
12-12: Exact-pin may introduce version skew & duplicatezstdcopiesLocking to
=0.13.3guarantees reproducibility, but:• Cargo will be forced to pull another copy if any transitive dep requires
0.13.4(security patch) or0.14, inflating binary size.
• You’ll also miss upstream patch-level fixes unless you bump manually.Consider a workspace-wide override instead:
# In the top-level Cargo.toml [patch.crates-io] zstd = { version = "0.13.3", package = "zstd" }This keeps a single, exact version while letting individual crates keep semver ranges. Verify no duplicate
zstdversions creep in:cargo tree -p encoder-standard | grep zstd
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
libzstd/encoder-standard/Cargo.toml(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: colinlyguo
PR: scroll-tech/da-codec#25
File: encoding/codecv1_types.go:105-116
Timestamp: 2024-10-18T03:40:09.800Z
Learning: The code in `encoding/codecv1_types.go`, specifically the `Encode` method in `daBatchV1`, has been updated. Previous comments regarding hardcoded byte offsets may be outdated.
libzstd/encoder-standard/Cargo.toml (1)
Learnt from: colinlyguo
PR: scroll-tech/da-codec#25
File: encoding/codecv1_types.go:105-116
Timestamp: 2024-10-18T03:40:09.800Z
Learning: The code in `encoding/codecv1_types.go`, specifically the `Encode` method in `daBatchV1`, has been updated. Previous comments regarding hardcoded byte offsets may be outdated.
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: check
- GitHub Check: tests
Purpose or design rationale of this PR
Exact same version as the one used in Reth, just to be safe.
Note: This does not change anything for this repo;
Cargo.lockalready locks to this version.PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Breaking change label
Does this PR have the
breaking-changelabel?Summary by CodeRabbit