Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: try to avoid reading mempool under load #1047

Closed
wants to merge 3 commits into from

Conversation

omerfirmak
Copy link

1. Purpose or design rationale of this PR

In the cases where we close a block due to some limit other than the timeout, there is a high chance that worker already has a bunch of txns at hand that it can include in the next block.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

colinlyguo
colinlyguo previously approved these changes Sep 19, 2024
Copy link
Member

@colinlyguo colinlyguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this optimization lead to "not full" blocks from time to time?

0xmountaintop
0xmountaintop previously approved these changes Sep 19, 2024
@omerfirmak omerfirmak dismissed stale reviews from 0xmountaintop and colinlyguo via 85fef6a September 19, 2024 08:18
@omerfirmak
Copy link
Author

Would this optimization lead to "not full" blocks from time to time?

Yes, there is a risk of decreasing the overall block space utilization.

// Fill the block with all available pending transactions.
pending := w.eth.TxPool().PendingWithMax(false, w.config.MaxAccountsNum)

pending := w.pendingTxns
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, ownership of pending gets transferred to TransactionsByPriceAndNonce once NewTransactionsByPriceAndNonce is called. So we can't just reuse the map as a whole without cloning it first.

@omerfirmak omerfirmak closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants