Dedup hash traces and add comment explaining +1 in n_rows_required

scroll-tech · Oct 10, 2023 · 36344ac · 36344ac
1 parent 862066e
commit 36344ac
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/gadgets/mpt_update.rs b/src/gadgets/mpt_update.rs
@@ -605,6 +605,7 @@ impl MptUpdateConfig {
     }
 
     pub fn n_rows_required(proofs: &[Proof]) -> usize {
+        // +1 because assigment starts on offset = 1 instead of offset = 0.
         proofs.iter().map(Proof::n_rows).sum::<usize>() + 1
     }
 
@@ -2097,6 +2098,8 @@ pub fn hash_traces(proofs: &[Proof]) -> Vec<([Fr; 2], Fr, Fr)> {
             }
         }
     }
+    hash_traces.sort();
+    hash_traces.dedup();
     hash_traces
 }