Skip to content

Commit

Permalink
clippy
Browse files Browse the repository at this point in the history
  • Loading branch information
Mason Liang committed Oct 24, 2023
1 parent 1b8ac85 commit eb57ded
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 9 deletions.
6 changes: 3 additions & 3 deletions src/assignment_map.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ use crate::constraint_builder::{
use halo2_proofs::{
arithmetic::FieldExt,
circuit::{Region, Value},
halo2curves::bn256::Fr,
plonk::{Challenge, ConstraintSystem, Error, Expression, VirtualCells},
plonk::Error,
};
use rayon::prelude::*;
use std::collections::HashMap;
Expand Down Expand Up @@ -79,7 +78,8 @@ impl<F: FieldExt> AssignmentMap<F> {
Column::SecondPhaseAdvice(s) => {
region.assign_advice(|| "second phase advice", s.0, offset, || value)
}
};
}
.unwrap();
}
Ok(())
}]
Expand Down
5 changes: 3 additions & 2 deletions src/gadgets/byte_bit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use crate::assignment_map::Column;
use halo2_proofs::{
arithmetic::FieldExt,
circuit::{Region, Value},
plonk::{ConstraintSystem, Error},
plonk::ConstraintSystem,
};
use rayon::prelude::*;

Expand Down Expand Up @@ -42,7 +42,8 @@ impl ByteBitGadget {
match column {
Column::Fixed(s) => region.assign_fixed(|| "fixed", s.0, offset, || value),
_ => unreachable!(),
};
}
.unwrap();
}
}

Expand Down
3 changes: 2 additions & 1 deletion src/gadgets/byte_representation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,8 @@ impl ByteRepresentationConfig {
region.assign_advice(|| "second phase advice", s.0, offset, || value)
}
_ => unreachable!(),
};
}
.unwrap();
}
}

Expand Down
3 changes: 2 additions & 1 deletion src/gadgets/canonical_representation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,8 @@ impl CanonicalRepresentationConfig {
Column::SecondPhaseAdvice(s) => {
region.assign_advice(|| "second phase advice", s.0, offset, || value)
}
};
}
.unwrap();
}
}

Expand Down
4 changes: 3 additions & 1 deletion src/gadgets/key_bit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,9 @@ impl KeyBitConfig {
let assignments: Vec<_> = self.assignments(lookups).collect();
for ((column, offset), value) in assignments.into_iter() {
match column {
Column::Advice(s) => region.assign_advice(|| "advice", s.0, offset, || value),
Column::Advice(s) => region
.assign_advice(|| "advice", s.0, offset, || value)
.unwrap(),
_ => unreachable!(),
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/mpt.rs
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ impl MptCircuitConfig {

Ok(())
},
);
)?;

let mut keys = mpt_update_keys(proofs);
keys.sort();
Expand Down

0 comments on commit eb57ded

Please sign in to comment.