Bring main up to date with latest branch #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
March 6, 2023 18:22
Co-authored-by: Mason Liang <[email protected]>
Co-authored-by: Mason Liang <[email protected]>
Co-authored-by: Mason Liang <[email protected]>
…ode_size (#64) Co-authored-by: Mason Liang <[email protected]>
Co-authored-by: Mason Liang <[email protected]>
Co-authored-by: Mason Liang <[email protected]>
Co-authored-by: Mason Liang <[email protected]>
* Check that nonce and code size are 0 new account leaf * Remove unreachable condition --------- Co-authored-by: Mason Liang <[email protected]>
* Add is_first selector to handle wraparound for .previous * Remove unneeded condition * Correct constraint name --------- Co-authored-by: Mason Liang <[email protected]>
* Add failing tests * Add failing empty mpt empty account proof test * Handle case of singleton and empty mpt's --------- Co-authored-by: Mason Liang <[email protected]>
* Handle case for proving 0 balance, nonce, keccak code hash, code size, and empty storage updates in an empty mpt * Add singleton_mpt_empty_account test * Fix documentation --------- Co-authored-by: Mason Liang <[email protected]>
* Add comment explaining why we don't need to range check address_low * [ZK 2-23] add check that final mpt update row is padding (#85) * Add check that final mpt update row is padding * fmt * Use constraints instead of lookups * Fix assert --------- Co-authored-by: Mason Liang <[email protected]> * Add range check for address_low * camel case test name --------- Co-authored-by: naure <[email protected]> Co-authored-by: Mason Liang <[email protected]>
Co-authored-by: Mason Liang <[email protected]>
* fix column annotation * Implement n_rows_required for internal gadgets * Add n_rows_required implementation for MptUpdateGadget * clippy and add 1 to account for disabled row in MptUpdateConfig * Start assignment from second row * Remove panic * Add comments explaining where +1 comes from * Add test for fixed vk * Dedup hash traces and add comment explaining +1 in n_rows_required * Fix comment * Fix build * Track Cargo.lock --------- Co-authored-by: Mason Liang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.