Skip to content

feat: limit rollup fee in tx pool #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: scroll
Choose a base branch
from
Open

Conversation

greged93
Copy link
Collaborator

@greged93 greged93 commented Aug 8, 2025

Resolves #305.

@greged93 greged93 requested a review from frisitano August 8, 2025 15:38
@github-actions github-actions bot added enhancement New feature or request good first issue Good for newcomers labels Aug 8, 2025
Copy link

codspeed-hq bot commented Aug 8, 2025

CodSpeed Performance Report

Merging #316 will not alter performance

Comparing feat/limit-rollup-fee (3e3c9ca) with scroll (40affdf)

Summary

✅ 77 untouched benchmarks

@greged93 greged93 requested a review from colinlyguo August 11, 2025 11:19
colinlyguo
colinlyguo previously approved these changes Aug 11, 2025
Thegaram
Thegaram previously approved these changes Aug 11, 2025
Signed-off-by: Gregory Edison <[email protected]>
@greged93 greged93 dismissed stale reviews from Thegaram and colinlyguo via 6eee35c August 11, 2025 14:42
Thegaram
Thegaram previously approved these changes Aug 11, 2025
* feat: add maxTxPayloadBytesPerBlock to ScrollChainConfig

Signed-off-by: Gregory Edison <[email protected]>

* feat: limit pool max tx input bytes

Signed-off-by: Gregory Edison <[email protected]>

* test: set max_tx_payload_bytes_per_block

Signed-off-by: Gregory Edison <[email protected]>

* feat: make MockEthProvider more generic

Signed-off-by: Gregory Edison <[email protected]>

* test: add pool limit tests

Signed-off-by: Gregory Edison <[email protected]>

* fix: lints

Signed-off-by: Gregory Edison <[email protected]>

---------

Signed-off-by: Gregory Edison <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transactions with rollup fee > u64::MAX at tx pool
3 participants