feat: limit pool tx size #317
Conversation
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
CodSpeed Performance ReportMerging #317 will not alter performanceComparing Summary
|
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
| @@ -68,6 +68,7 @@ where | |||
| .with_local_transactions_config( | |||
| pool_config_overrides.clone().apply(ctx.pool_config()).local_transactions_config, | |||
| ) | |||
| .with_max_tx_input_bytes(ctx.chain_spec().chain_config().max_tx_payload_bytes_per_block) | |||
There was a problem hiding this comment.
Just a few notes:
- Here we only check
tx.input, but the overall transaction could be much larger (e.g. by including a long authorization list). - Also, if
tx.input == max_payload_size, then we'll admin it into the txpool, but we must not include it in the block (the full serialized block must respect the same limit).
That said, this is not very critical, and the current impl seems idential to l2geth. The critical part is ensuring these limits during block building.
There was a problem hiding this comment.
Was not aware of the second point, can always add this to the block builder, it's not much. For the first point, I think we check tx.rlp_encoding_length so this should cover the authorization list.
There was a problem hiding this comment.
This check is here: https://github.com/scroll-tech/go-ethereum/blob/develop/miner/scroll_worker.go#L836. Yes we should add it to the block builder.
There was a problem hiding this comment.
After a check, this was implemented by Morty here.
Resolves #310