Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (libzkp): upgrade to use prover v0.9.8 and add strict-ccc feature #1015

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

silathdiir
Copy link
Contributor

@silathdiir silathdiir commented Nov 20, 2023

Purpose or design rationale of this PR

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@silathdiir silathdiir added breaking-change bump-version Bump the version tag for deployment labels Nov 20, 2023
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4aa5d5c) 48.01% compared to head (2ad2a60) 48.00%.

❗ Current head 2ad2a60 differs from pull request most recent head c1907b2. Consider uploading reports for the commit c1907b2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1015      +/-   ##
===========================================
- Coverage    48.01%   48.00%   -0.01%     
===========================================
  Files          101      101              
  Lines        10665    10671       +6     
===========================================
+ Hits          5121     5123       +2     
- Misses        5116     5120       +4     
  Partials       428      428              
Flag Coverage Δ
common 54.94% <ø> (ø)
coordinator 18.91% <ø> (ø)
database 42.85% <ø> (ø)
prover 27.32% <ø> (ø)
rollup 66.02% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@silathdiir
Copy link
Contributor Author

test_zkp could pass.

Screen Shot 2023-11-20 at 8 17 12 PM

@silathdiir silathdiir changed the title [Testing] fix (libzkp): upgrade to use prover v0.9.8, and add strict-ccc feature fix (libzkp): upgrade to use prover v0.9.8, and add strict-ccc feature Nov 20, 2023
@silathdiir silathdiir changed the title fix (libzkp): upgrade to use prover v0.9.8, and add strict-ccc feature fix (libzkp): upgrade to use prover v0.9.8 and add strict-ccc feature Nov 20, 2023
@georgehao georgehao merged commit 144c7ed into develop Nov 22, 2023
@georgehao georgehao deleted the libzkp-v0.9.8 branch November 22, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants