Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typos #1025

Merged
merged 15 commits into from
Dec 14, 2023
Merged

docs: fix typos #1025

merged 15 commits into from
Dec 14, 2023

Conversation

nnsW3
Copy link
Contributor

@nnsW3 nnsW3 commented Dec 6, 2023

Hello,
I fixed several typos found in your documentation.
Hope it helps.
Best regards, Elias.

0xmountaintop
0xmountaintop previously approved these changes Dec 8, 2023
@0xmountaintop 0xmountaintop changed the title Fix typos docs: fix typos Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (1264f82) 48.90% compared to head (eac124a) 48.90%.

Files Patch % Lines
bridge-history-api/crossmsg/batch_info_fetcher.go 0.00% 2 Missing ⚠️
common/cmd/cmd_app.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1025   +/-   ##
========================================
  Coverage    48.90%   48.90%           
========================================
  Files          158      158           
  Lines        12710    12710           
========================================
  Hits          6216     6216           
  Misses        6064     6064           
  Partials       430      430           
Flag Coverage Δ
bridge-history-api 11.11% <0.00%> (ø)
common 55.05% <0.00%> (ø)
coordinator 18.91% <ø> (ø)
database 42.85% <ø> (ø)
rollup 66.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

build/.golangci.yml Outdated Show resolved Hide resolved
This was referenced Dec 11, 2023
@georgehao
Copy link
Member

@nnsW3 pls fix the conflict

@nnsW3
Copy link
Contributor Author

nnsW3 commented Dec 13, 2023

solved it

@0xmountaintop 0xmountaintop merged commit 7157382 into scroll-tech:develop Dec 14, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants