Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: printf without placeholder #1034

Closed

Conversation

machinly
Copy link
Contributor

@machinly machinly commented Dec 8, 2023

Purpose or design rationale of this PR

Some Fatalf functions lack placeholders, and the underlying implementation uses Fprintf. This could lead to issues with properly printing error messages.

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (db07180) 48.90% compared to head (8e4809c) 48.04%.

❗ Current head 8e4809c differs from pull request most recent head 02923d1. Consider uploading reports for the commit 02923d1 to get more accurate results

Files Patch % Lines
bridge-history-api/utils/logger.go 0.00% 1 Missing ⚠️
common/utils/logger.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1034      +/-   ##
===========================================
- Coverage    48.90%   48.04%   -0.87%     
===========================================
  Files          158      101      -57     
  Lines        12710    10697    -2013     
===========================================
- Hits          6216     5139    -1077     
+ Misses        6064     5128     -936     
  Partials       430      430              
Flag Coverage Δ
bridge-history-api 11.11% <0.00%> (ø)
common 55.05% <0.00%> (ø)
contracts ?
coordinator 18.91% <ø> (ø)
database 42.85% <ø> (ø)
rollup 66.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

georgehao
georgehao previously approved these changes Dec 13, 2023
@machinly machinly closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants