Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade go version to 1.20 #1045

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Conversation

georgehao
Copy link
Member

@georgehao georgehao commented Dec 13, 2023

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

  1. update the contribute docs
  2. update the format tool
  3. delete l2geth submodule

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (566fb23) 48.04% compared to head (e8c25fb) 48.04%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1045   +/-   ##
========================================
  Coverage    48.04%   48.04%           
========================================
  Files          101      101           
  Lines        10697    10697           
========================================
  Hits          5139     5139           
  Misses        5128     5128           
  Partials       430      430           
Flag Coverage Δ
bridge-history-api 11.11% <ø> (ø)
common 55.05% <ø> (ø)
coordinator 18.91% <ø> (ø)
database 42.85% <ø> (ø)
prover 27.32% <ø> (ø)
rollup 66.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgehao georgehao force-pushed the feat/update-contribute-docs branch from 520b51e to 174d7c5 Compare December 13, 2023 03:32
@0xmountaintop 0xmountaintop changed the title feat(docs): update the contribute docs and tool build: upgrade go version to 1.20 Dec 13, 2023
Copy link
Member

@colinlyguo colinlyguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@georgehao georgehao merged commit 7dd1b05 into develop Dec 13, 2023
27 checks passed
@georgehao georgehao deleted the feat/update-contribute-docs branch December 13, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants