Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update some layer logic #1050

Merged

Conversation

georgehao
Copy link
Member

@georgehao georgehao commented Dec 14, 2023

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (2f7e329) 55.53% compared to head (230947f) 55.45%.

Files Patch % Lines
bridge-history-api/internal/utils/utils.go 0.00% 16 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##           fix-bridge-history-api-write-db    #1050      +/-   ##
===================================================================
- Coverage                            55.53%   55.45%   -0.09%     
===================================================================
  Files                                  145      145              
  Lines                                11089    11105      +16     
===================================================================
  Hits                                  6158     6158              
- Misses                                4510     4526      +16     
  Partials                               421      421              
Flag Coverage Δ
bridge-history-api 57.97% <0.00%> (-3.85%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colinlyguo colinlyguo merged commit 7011c3e into fix-bridge-history-api-write-db Dec 14, 2023
@colinlyguo colinlyguo deleted the feat/bridge_history_some_change branch December 14, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants