-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #1042 Allow configure db ConnMaxLifetime & ConnMaxIdleTime #1207
feat: #1042 Allow configure db ConnMaxLifetime & ConnMaxIdleTime #1207
Conversation
@HAOYUatHZ Please review. |
4238c9a
to
2228b41
Compare
…feat/issue-1042_config
…l into feat/issue-1042_config
…feat/issue-1042_config
…feat/issue-1042_config
…feat/issue-1042_config
…feat/issue-1042_config
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1207 +/- ##
===========================================
+ Coverage 56.11% 56.39% +0.28%
===========================================
Files 156 158 +2
Lines 12131 12293 +162
===========================================
+ Hits 6807 6933 +126
- Misses 4798 4820 +22
- Partials 526 540 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CI fails |
…feat/issue-1042_config
Resolved. |
hi @jeswinsimon the CI fails again. can you fix them? so that we can merge it soon |
This pr hasn't been updated in a long time, close it. if necessary, pls reopen it |
Purpose or design rationale of this PR
Allow
connMaxLifetime
andconnMaxIdleTime
to be configured for database connections.Fixed #1042.
feat: #1042 Allow configure db ConnMaxLifetime & ConnMaxIdleTime
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated or have you addedbump-version
label to this PR?Breaking change label
Does this PR have the
breaking-change
label?