Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rollup-relayer): finalize bundle #1411

Merged
merged 29 commits into from
Jul 8, 2024
Merged

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Jul 2, 2024

Purpose or design rationale of this PR

  1. add bundle-proposer.
  2. finalize bundles.
  • db unit tests.
  • bundle proposer unit tests.
  • l2 relayer unit tests.
  • integration tests.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 56.47668% with 252 lines in your changes missing coverage. Please review.

Project coverage is 54.29%. Comparing base (beee0c2) to head (9316e45).

Files Patch % Lines
rollup/internal/controller/relayer/l2_relayer.go 37.95% 83 Missing and 20 partials ⚠️
rollup/internal/orm/bundle.go 63.84% 44 Missing and 20 partials ⚠️
...lup/internal/controller/watcher/bundle_proposer.go 68.64% 27 Missing and 10 partials ⚠️
rollup/internal/orm/batch.go 58.90% 23 Missing and 7 partials ⚠️
common/types/message/message.go 0.00% 18 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           feat/upgrade4    #1411      +/-   ##
=================================================
+ Coverage          53.80%   54.29%   +0.49%     
=================================================
  Files                156      158       +2     
  Lines              12061    12605     +544     
=================================================
+ Hits                6489     6844     +355     
- Misses              5067     5193     +126     
- Partials             505      568      +63     
Flag Coverage Δ
bridge-history-api 72.50% <ø> (ø)
common 46.53% <0.00%> (-0.54%) ⬇️
coordinator 19.93% <ø> (ø)
database 42.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colinlyguo colinlyguo requested review from Thegaram and zimpha July 4, 2024 20:16
@colinlyguo colinlyguo mentioned this pull request Jul 7, 2024
13 tasks
@colinlyguo colinlyguo requested a review from amoylan2 July 7, 2024 16:04
@georgehao georgehao merged commit bc9bc5d into feat/upgrade4 Jul 8, 2024
16 checks passed
@georgehao georgehao deleted the finalize-bundle branch July 8, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants