-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bridge-history): generate withdraw proofs by bundle #1415
Merged
colinlyguo
merged 7 commits into
develop
from
bridge-history-generate-withdraw-proof-by-bundle
Jul 10, 2024
Merged
feat(bridge-history): generate withdraw proofs by bundle #1415
colinlyguo
merged 7 commits into
develop
from
bridge-history-generate-withdraw-proof-by-bundle
Jul 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1415 +/- ##
========================================
Coverage 53.53% 53.53%
========================================
Files 155 155
Lines 11655 11655
========================================
Hits 6239 6239
Misses 4930 4930
Partials 486 486
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zimpha
previously approved these changes
Jul 9, 2024
georgehao
previously approved these changes
Jul 9, 2024
change the target branch |
zimpha
approved these changes
Jul 10, 2024
georgehao
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or design rationale of this PR
This PR adds generating withdraw proofs by bundle logic, and it's backward compatible.
Notes:
It keeps commit/revert batches to maintain block range of the batch, because in
FinalizeBatch
event, there isn't a block range.Only updating batch's status as
finalized
when listening to theFinalizeBatch
event (when "finalize by bundle", only each bundle's last batch will be updated asfinalized
), so that bridge-history-backend can track the block range to update regardless "finalize by batch" or "finalize by bundle".This PR is compatible with both "finalize by batch" and "finalize by bundle" modes:
FinalizedBatch
event, using the last batch's index and hash.For withdraw proof generation:
For batch index updating:
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated or have you addedbump-version
label to this PR?Breaking change label
Does this PR have the
breaking-change
label?