Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): coordinator and bridge-history images #1417

Closed
wants to merge 15 commits into from

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Jul 9, 2024

Purpose or design rationale of this PR

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

@colinlyguo colinlyguo requested a review from georgehao July 9, 2024 09:31
@colinlyguo colinlyguo changed the title fix(build): coordinator-cron and coordinator-api images build fix(build): coordinator and bridge-history images build Jul 9, 2024
@colinlyguo colinlyguo changed the title fix(build): coordinator and bridge-history images build fix(build): coordinator and bridge-history images Jul 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.88%. Comparing base (abe66c6) to head (32fd01f).

Additional details and impacted files
@@                Coverage Diff                @@
##           feat/upgrade4    #1417      +/-   ##
=================================================
- Coverage          52.88%   52.88%   -0.01%     
=================================================
  Files                157      157              
  Lines              12407    12407              
=================================================
- Hits                6562     6561       -1     
- Misses              5293     5294       +1     
  Partials             552      552              
Flag Coverage Δ
bridge-history-api 72.50% <ø> (ø)
common 49.48% <ø> (-0.13%) ⬇️
coordinator 17.53% <ø> (ø)
database 42.85% <ø> (ø)
rollup 57.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colinlyguo
Copy link
Member Author

replaced with: #1421

@colinlyguo colinlyguo closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants