Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libzkp and coordinator updates (preparation for Upgrade4) #1419

Merged
merged 11 commits into from
Jul 11, 2024

Conversation

roynalnaruto
Copy link
Contributor

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

  • Update libzkp
    • Batch proof verification for fork id 3 and 4 supported
    • Chunk proof verification for fork id 3 and 4 supported
    • Update API as per prover v4
    • Additional code for constructing and verifying "bundle" proofs
  • Update coordinator
    • Corresponding updates as per above libzkp changes

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@roynalnaruto roynalnaruto requested a review from georgehao July 9, 2024 12:11
@roynalnaruto roynalnaruto changed the base branch from develop to feat/upgrade4 July 9, 2024 12:11
@roynalnaruto roynalnaruto requested a review from lispc July 9, 2024 12:11
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat/upgrade4@3567f5b). Learn more about missing BASE report.

Files Patch % Lines
coordinator/internal/orm/prover_task.go 16.66% 5 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             feat/upgrade4    #1419   +/-   ##
================================================
  Coverage                 ?   52.88%           
================================================
  Files                    ?      157           
  Lines                    ?    12407           
  Branches                 ?        0           
================================================
  Hits                     ?     6562           
  Misses                   ?     5293           
  Partials                 ?      552           
Flag Coverage Δ
common 49.61% <ø> (?)
coordinator 17.53% <16.66%> (?)
database 42.85% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgehao georgehao merged commit a2e8b6a into feat/upgrade4 Jul 11, 2024
13 checks passed
@georgehao georgehao deleted the feat/upgrade4-upgrade4 branch July 11, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants