Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump prover (upgrade #4) #1437

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

roynalnaruto
Copy link
Contributor

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

Bump version of prover_v4 (Upgrade#4)

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feat/upgrade4@04a893a). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             feat/upgrade4    #1437   +/-   ##
================================================
  Coverage                 ?   52.88%           
================================================
  Files                    ?      157           
  Lines                    ?    12407           
  Branches                 ?        0           
================================================
  Hits                     ?     6562           
  Misses                   ?     5293           
  Partials                 ?      552           
Flag Coverage Δ
common 49.61% <ø> (?)
coordinator 17.53% <ø> (?)
database 42.85% <ø> (?)
rollup 57.93% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgehao georgehao merged commit 3716c5a into feat/upgrade4 Jul 18, 2024
13 checks passed
@georgehao georgehao deleted the chore/upgrade4-bump-prover branch July 18, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants