-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sender): support web3signer #1524
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1524 +/- ##
===========================================
+ Coverage 51.81% 52.01% +0.20%
===========================================
Files 155 156 +1
Lines 12835 12974 +139
===========================================
+ Hits 6651 6749 +98
- Misses 5610 5641 +31
- Partials 574 584 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work and lgtm. just some very small nitpicks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
Purpose or design rationale of this PR
Instead of storing a private key in
config.json
(major risk of leaking secrets), we initialize a secure wallet(web3signer
) as a standalone service.rollup-relayer
will then send signing requests to this service.This PR adds desired functionality into
rollup-relayer
, specifically tosender
Currently
web3signer
doesn't supportBlobTx
, soCommitSender
still need sign txs ad before. Changed configuration relayer, so now type of signing may be changed (PrivateKey
orRemoteSigner
)task
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated or have you addedbump-version
label to this PR?Breaking change label
Does this PR have the
breaking-change
label?