chore: use errors.New to replace fmt.Errorf with no parameters

[RiceChuan]

use errors.New to replace fmt.Errorf with no parameters

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling for empty signer addresses and unknown signer types with standardized error messages.

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 golangci-lint (1.62.2)

level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for "scroll-tech/rollup/mock_bridge""
level=error msg="Running error: can't run linter goanalysis_metalinter\nbuildir: failed to load package : could not load export data: no export data for "scroll-tech/rollup/mock_bridge""

Walkthrough

The pull request introduces minor modifications to error handling in the transaction_signer.go file within the rollup's internal controller sender package. The changes focus on standardizing error creation by replacing fmt.Errorf with errors.New for specific error scenarios related to transaction signing. The core functionality of the transaction signing process remains unaltered, with the primary goal being consistent error message generation.

Changes

File	Change Summary
rollup/internal/controller/sender/transaction_signer.go	- Added errors package import - Replaced fmt.Errorf with errors.New for empty signer address error - Replaced fmt.Errorf with errors.New for unknown signer type error

Poem

🐰 A Rabbit's Error Handling Rhyme 🔧

In the code where signers dance and twirl,
Errors now wrapped with a cleaner unfurl
errors.New replaces the old fmt way
Consistency reigns on this coding day!
A small change, but neat as can be! 🎉

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. This feature will be included in our Pro Plan when released.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

rollup/internal/controller/sender/transaction_signer.go (1)

98-98: Consider enhancing the type safety of SignerType

While the change to errors.New is appropriate for this static message, the comment "shouldn't happen" suggests this case should be unreachable. Consider:

1. Making SignerType an enumerated type (const or custom type) instead of a string
2. Removing the default case entirely since types are validated during creation
3. If retained for defensive programming, adding logging for this unexpected scenario

Example enhancement:

type SignerType string

const (
    PrivateKeySignerType SignerType = "PrivateKey"
    RemoteSignerType     SignerType = "RemoteSigner"
)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 33b1b3c and b31cd16.

📒 Files selected for processing (1)

• rollup/internal/controller/sender/transaction_signer.go (3 hunks)

🔇 Additional comments (3)

rollup/internal/controller/sender/transaction_signer.go (3)

5-5: LGTM: Import addition is appropriate

The addition of the "errors" import is necessary and correctly placed for the planned error handling changes.

---

55-55: LGTM: Appropriate use of errors.New

The change from fmt.Errorf to errors.New is correct here as the error message is static and requires no formatting.

---

Line range hint 67-67: LGTM: Correctly retained fmt.Errorf

Appropriate retention of fmt.Errorf here as the error message requires parameter formatting for the signer type.