Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollup-relayer): update batch finalizing status and unify db time… #1582

Merged

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Dec 27, 2024

Purpose or design rationale of this PR

This PR solves two known issues:

  • https://scroll.io/rollupscan does not show "finalizing" status, it's due to the batch "finalizing" status is not updated.
  • The db timestamp timezone is not unified, this pr modifies all into Universal Coordinated Time.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

Summary by CodeRabbit

  • New Features
    • Updated version number to v4.4.84.
  • Improvements
    • Enhanced transaction handling for bundle finalization, ensuring atomic updates and better error management.
    • Standardized timestamp handling across various methods to use UTC format for improved accuracy.
    • Streamlined utility function usage by consolidating imports and renaming for consistency.

Copy link

coderabbitai bot commented Dec 27, 2024

Warning

Rate limit exceeded

@colinlyguo has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 27 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 5993aa5 and b01aade.

📒 Files selected for processing (1)
  • rollup/internal/controller/relayer/l2_relayer.go (2 hunks)

Walkthrough

This pull request introduces several incremental updates across multiple files in the rollup and version management components. The changes primarily focus on improving timestamp consistency by replacing time.Now() with utils.NowUTC(), enhancing database transaction handling in the L2 relayer, and making minor utility function adjustments. The version number is also incrementally updated from v4.4.83 to v4.4.84, indicating a minor release or patch.

Changes

File Change Summary
common/version/version.go Version number incremented from v4.4.83 to v4.4.84
rollup/internal/controller/relayer/l2_relayer.go Enhanced database transaction handling in finalizeBundle method for atomic updates and improved error management
rollup/internal/orm/batch.go Replaced time.Now() with utils.NowUTC() for timestamp updates in various status-related methods
rollup/internal/orm/bundle.go Standardized timestamp generation using utils.NowUTC() in status update methods
rollup/internal/orm/chunk.go Updated import statements, renamed utility package, and replaced timestamp generation method

Sequence Diagram

sequenceDiagram
    participant Relayer
    participant Database
    participant Bundle
    participant Batch

    Relayer->>Bundle: finalizeBundle
    Bundle-->>Relayer: Begin Transaction
    Relayer->>Database: Update Bundle Status
    Relayer->>Database: Update Batch Status
    alt Transaction Successful
        Relayer-->>Bundle: Commit Transaction
    else Transaction Failed
        Relayer-->>Bundle: Rollback Transaction
        Relayer-->>Relayer: Handle Error
    end
Loading

Poem

🐰 Version bumps and code so neat,
Timestamps dancing to UTC's beat
Transactions wrapped with tender care
Rollup logic beyond compare
A rabbit's code, precise and light! 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

georgehao
georgehao previously approved these changes Dec 27, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 40.74074% with 16 lines in your changes missing coverage. Please review.

Project coverage is 52.01%. Comparing base (45b23ed) to head (b01aade).

Files with missing lines Patch % Lines
rollup/internal/controller/relayer/l2_relayer.go 23.07% 7 Missing and 3 partials ⚠️
rollup/internal/orm/batch.go 20.00% 4 Missing ⚠️
rollup/internal/orm/chunk.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1582      +/-   ##
===========================================
- Coverage    52.04%   52.01%   -0.03%     
===========================================
  Files          157      157              
  Lines        12465    12475      +10     
===========================================
+ Hits          6487     6489       +2     
- Misses        5418     5424       +6     
- Partials       560      562       +2     
Flag Coverage Δ
rollup 56.98% <40.74%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colinlyguo colinlyguo merged commit f92029a into develop Dec 30, 2024
6 checks passed
@colinlyguo colinlyguo deleted the fix-rollup-relayer-update-batch-RollupFinalizing-status branch December 30, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants