Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libzkp): upgrade libzkp to use prover v0.9.1 #948

Merged
merged 3 commits into from
Sep 17, 2023

Conversation

silathdiir
Copy link
Contributor

@silathdiir silathdiir commented Sep 16, 2023

Purpose or design rationale of this PR

Upgrade libzkp to use prover v0.9.1.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #948 (a84312e) into develop (2a54c8a) will not change coverage.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

❗ Current head a84312e differs from pull request most recent head 8877ee4. Consider uploading reports for the commit 8877ee4 to get more accurate results

@@           Coverage Diff            @@
##           develop     #948   +/-   ##
========================================
  Coverage    50.33%   50.33%           
========================================
  Files           96       96           
  Lines         9993     9993           
========================================
  Hits          5030     5030           
  Misses        4549     4549           
  Partials       414      414           
Flag Coverage Δ
common 54.56% <ø> (ø)
coordinator 18.94% <ø> (ø)
database 42.85% <ø> (ø)
rollup 66.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@silathdiir
Copy link
Contributor Author

test_zkp could pass.

Screen Shot 2023-09-17 at 1 59 40 AM

@silathdiir silathdiir changed the title [Testing] fix(libzkp): upgrade libzkp to use prover v0.9.1 fix(libzkp): upgrade libzkp to use prover v0.9.1 Sep 16, 2023
0xmountaintop
0xmountaintop previously approved these changes Sep 17, 2023
@0xmountaintop 0xmountaintop added the bump-version Bump the version tag for deployment label Sep 17, 2023
@0xmountaintop 0xmountaintop merged commit 5eed174 into develop Sep 17, 2023
@0xmountaintop 0xmountaintop deleted the libzkp-v0.9.1 branch September 17, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants