Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libzkp): try to convert to string for panic errors #949

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

silathdiir
Copy link
Contributor

Purpose or design rationale of this PR

Reference this panic-handling code of zkevm-circuits testool, fix to the similar logic in libzkp (to avoid returning error as Any {...}).

Suppose to test again and release in next version.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #949 (f872f56) into develop (5eed174) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #949   +/-   ##
========================================
  Coverage    50.29%   50.29%           
========================================
  Files           96       96           
  Lines        10001    10001           
========================================
  Hits          5030     5030           
  Misses        4557     4557           
  Partials       414      414           
Flag Coverage Δ
common 54.56% <ø> (ø)
coordinator 18.80% <ø> (ø)
database 42.85% <ø> (ø)
rollup 66.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

0xmountaintop
0xmountaintop previously approved these changes Sep 19, 2023
colinlyguo
colinlyguo previously approved these changes Sep 19, 2023
@0xmountaintop 0xmountaintop added bump-version Bump the version tag for deployment and removed bump-version Bump the version tag for deployment labels Sep 19, 2023
@github-actions github-actions bot dismissed stale reviews from colinlyguo and 0xmountaintop via 66a8c88 September 19, 2023 03:40
@0xmountaintop 0xmountaintop force-pushed the better-panic-catch-in-libzkp branch from 66a8c88 to f872f56 Compare September 19, 2023 03:42
@0xmountaintop 0xmountaintop merged commit f092036 into develop Sep 19, 2023
35 checks passed
@0xmountaintop 0xmountaintop deleted the better-panic-catch-in-libzkp branch September 19, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants